Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Newtonsoft.Json to 13.0.3 #168

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

janusw
Copy link
Member

@janusw janusw commented Jul 4, 2023

No description provided.

@janusw janusw force-pushed the update_NewtosoftJson branch from 6a18410 to 2e60a49 Compare February 14, 2024 20:51
@xfischer
Copy link
Member

Why did you update to this version ? We tend to keep satellite assemblies to the lowest version possible (unless vulnerabilities are discovered) to avoid conflicts for consumers (ie: they are using a package that references a lower version of Newtonsoft.JSON). Unless you find this is a bad pratice or useless, is it required ?

@janusw
Copy link
Member Author

janusw commented Feb 28, 2024

Sorry for posting this PR without any comment. As far as I'm concerned, it's good practice to keep dependencies up to date, in order to include all the latest bugfixes and improvements.

In this case, I'm not updating the package for a particular fix, but just to have the latest version (for good practice).

I guess it's up to you, whether you want to merge this or not. It's probably not completely unreasonable to be a bit more conservative about the dependencies, and only update if it's really necessary (updates can potentially introduce new bugs and problems as well).

@janusw janusw force-pushed the update_NewtosoftJson branch from 2e60a49 to a4e0021 Compare February 28, 2024 20:23
@janusw
Copy link
Member Author

janusw commented Feb 28, 2024

In any case, I rebased it to current master now, in order to take advantage of the latest GHA enhancements.

@janusw janusw mentioned this pull request Jul 8, 2024
@janusw janusw force-pushed the update_NewtosoftJson branch from a4e0021 to e931037 Compare July 8, 2024 13:19
@xfischer xfischer merged commit 7f46cdd into GeoJSON-Net:master Jul 8, 2024
2 checks passed
@janusw janusw deleted the update_NewtosoftJson branch July 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants